Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default value for version #27

Closed
wants to merge 1 commit into from

Conversation

turion
Copy link
Contributor

@turion turion commented Jan 7, 2024

It would be cool if one doesn't have to specify the version as an input.

@turion turion marked this pull request as ready for review January 7, 2024 11:33
steps:
- name: Extract the tested GHC versions
id: set-matrix
uses: turion/[email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed back at the end.

@Kleidukos
Copy link
Owner

hmm I don't agree too much with this, it makes things easier to have the version of the tool written down somewhere. Moreover, right now the version of the tool and the action are the same by accident, I will think of moving the action elsewhere (in @haskell-actions for instance), and then it will be a totally different number.

@turion
Copy link
Contributor Author

turion commented Jan 7, 2024

You are definitely right there in principle. My motivation was the following: I like and use get-tested a lot, but one common source of errors was that I used a newer GHC version than my pinned get-tested version supported. If the version of the action is bumped every time the version of the tool is bumped, then dependabot can automatically bump that version in my local usage of the action. If you want to decouple the two, you would have double the maintenance effort by bumping two versions.

@Kleidukos
Copy link
Owner

Ah yes that was a problem of fixed known GHC versions, but I've removed this behaviour: 3e5545e

@Kleidukos
Copy link
Owner

(or perhaps were you thinking of something else?)

@turion
Copy link
Contributor Author

turion commented Jan 7, 2024

I just tested and it seems that is exactly the thing :D ok, in that case my workflow doesn't depend so crucially on the get-tested version anymore and all is well. Thanks!

@turion turion closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants