-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide default value for version #27
Conversation
steps: | ||
- name: Extract the tested GHC versions | ||
id: set-matrix | ||
uses: turion/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be changed back at the end.
hmm I don't agree too much with this, it makes things easier to have the version of the tool written down somewhere. Moreover, right now the version of the tool and the action are the same by accident, I will think of moving the action elsewhere (in @haskell-actions for instance), and then it will be a totally different number. |
You are definitely right there in principle. My motivation was the following: I like and use |
Ah yes that was a problem of fixed known GHC versions, but I've removed this behaviour: 3e5545e |
(or perhaps were you thinking of something else?) |
I just tested and it seems that is exactly the thing :D ok, in that case my workflow doesn't depend so crucially on the |
It would be cool if one doesn't have to specify the version as an input.